Merged
Conversation
With the +1 overlap, both adjacent tiles were generating skirt wall triangles along their shared boundary — overlapping geometry facing opposite directions. Now _add_tile_skirt accepts an edges flag tuple and _build_tile_mesh only requests skirt on exterior (terrain boundary) edges.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #83 / closes #79
Summary
_add_tile_skirtnow accepts anedges=(top, right, bottom, left)flag tuple_build_tile_meshonly requests skirt on exterior edges (where a tile touches the terrain boundary). Interior tiles get zero skirt geometry.Test plan
pytest rtxpy/tests/test_lod.py— 33/33 pass (3 new tests for edge-selective skirt)